search

schibsted / account-sdk-browser

Schibsted Account SDK for browsers
https://schibsted.github.io/account-sdk-browser/
MIT License
16 stars 11 forks source link

fix: improve Identity types #250

Closed bukowskiadam closed 1 year ago

bukowskiadam commented 1 year ago

Class Identity extends EventEmitter in the JS file, but it's not typed for TS.

codecov[bot] commented 1 year ago

Codecov Report

Merging #250 (15d6deb) into master (e2b12af) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 15d6deb differs from pull request most recent head b6162af. Consider uploading reports for the commit b6162af to get more accurate results

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          13       13           
  Lines         478      478           
  Branches       96       96           
=======================================
  Hits          477      477           
  Misses          1        1

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

bukowskiadam commented 1 year ago

You know that I can't merge it? 😏 You have to do it 😉

bogdan-niculescu-sch commented 1 year ago

merged, and started release 4.7.4 👍