search

schibsted / account-sdk-browser

Schibsted Account SDK for browsers
https://schibsted.github.io/account-sdk-browser/
MIT License
16 stars 11 forks source link

fix: delete sessionCallBlocked only by the same tab that added entry #279

Open bogdan-niculescu-sch opened 7 months ago

bogdan-niculescu-sch commented 7 months ago

Currently, since local storage is shared between tabs, other tabs can clean session-service stop switch. Added logic to save tabId to sessionCallBlocked-cache instead of boolean value, and clean this entry only if tabId value matches

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 69.35484% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 97.10%. Comparing base (8ade01a) to head (8bf20df). Report is 3 commits behind head on master.

:exclamation: Current head 8bf20df differs from pull request most recent head 784c923. Consider uploading reports for the commit 784c923 to get more accurate results

Files Patch % Lines
src/identity.js 69.35% 15 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #279 +/- ## ========================================== - Coverage 99.85% 97.10% -2.75% ========================================== Files 14 14 Lines 668 692 +24 Branches 176 179 +3 ========================================== + Hits 667 672 +5 - Misses 1 16 +15 - Partials 0 4 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.