search

schibsted / account-sdk-browser

Schibsted Account SDK for browsers
https://schibsted.github.io/account-sdk-browser/
MIT License
16 stars 11 forks source link

Remove refs to ‘window’ from global scope #42

Closed torarvid closed 6 years ago

torarvid commented 6 years ago

Fixes #41 (I hope..)

This was an issue for people using server-side rendering, where simply importing a file will break when there are references to window at the root level of a file.

codecov[bot] commented 6 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          14       14           
  Lines         403      403           
  Branches       83       83           
=======================================
  Hits          379      379           
  Misses         23       23           
  Partials        1        1
Impacted Files Coverage Δ
src/identity.js 91.03% <100%> (ø) :arrow_up:
src/RESTClient.js 100% <100%> (ø) :arrow_up:
src/monetization.js 100% <100%> (ø) :arrow_up:
src/payment.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48801ce...88183c8. Read the comment docs.

Kicu commented 6 years ago

Tested locally and it works! Thanks, looking forward to having this merged