search

schibsted / account-sdk-ios

⛔️ DEPRECATED SchibstedAccount SDK for iOS
MIT License
6 stars 16 forks source link

Added support for logging in using shared web credentials #319

Closed clausjoergensen closed 4 years ago

clausjoergensen commented 4 years ago

Follow-up to #314 where we fetch the credentials from the shared web credentials, allowing the user to quickly login like seen here:

login

vmagaziy commented 4 years ago

Something is wrong with styling when T&C are presented in the flow:

Screen Shot 2020-11-18 at 10 13 26

clausjoergensen commented 4 years ago

Something is wrong with styling when T&C are presented in the flow:

Everything looks correct to me on that screenshot.

vmagaziy commented 4 years ago

The properly styled T&C page looks like this:

Screen Shot 2020-11-18 at 10 19 47

Notice the colours of buttons and checkboxes.

clausjoergensen commented 4 years ago

@vmagaziy the theme have been fixed now.

clausjoergensen commented 4 years ago

I moved all the cleanup to #322

clausjoergensen commented 4 years ago

@zamzterz I pushed a update using CompleteProfileCoordinator, I've verified it with the Terms&Conditions flow, seems to work.

clausjoergensen commented 4 years ago

@zamzterz ah, no. Using this coordinator breaks the login flow because it attempts to present the UI. We can't have it present anything, no spinner, no nothing, unless it has to.

This is what it looks like in a successful scenario for a user who don't need to agree / accept anything:

IMG_0591