Upgrade to Xcode 12 - Githubissues

schibsted / account-sdk-ios

⛔️ DEPRECATED SchibstedAccount SDK for iOS

MIT License

6 stars 16 forks source link

Upgrade to Xcode 12 #322

Closed clausjoergensen closed 3 years ago

clausjoergensen commented 3 years ago

Removed Carthage as it's not compatible with Xcode 12
Updated to the latest Quick&Nimble for Xcode 12 support.
Ran the linter (for what appears to be the first time in a while)
Fixed swiftlint errors.
Fixed various compilation errors in the tests.
Disabled Jazzy's check for undocumented methods, as this clearly hadn't been checked for a very long time.
Updated CI scripts to reflect the above changes.

clausjoergensen commented 3 years ago

These tests seems to be unstable

Failing tests:
    SchibstedAccountTests:
        IdentityManagerTests.Login_with_password__Should_pass_in_a_credential()
        TaskManagerTests.Adding_a_task__should_not_refresh_if_already_in_progress()
        TaskManagerTests.Adding_a_task__should_not_refresh_if_already_in_progress()