Cut a release with Swift 3.0 support to Cocoapods

schickling / Device.swift

Super-lightweight library to detect used device

MIT License

221 stars 70 forks source link

Cut a release with Swift 3.0 support to Cocoapods #21

Closed RyanRamchandar closed 8 years ago

RyanRamchandar commented 8 years ago

Xcode 8 is now released and there are build errors when using the latest pod (Device.swift 0.3.1) with Swift 3.0 as seen in #19 .

RyanRamchandar commented 8 years ago

In the mean time you can use the following as a workaround in your Podfile, since support is in master just not released as a pod yet:

pod 'Device.swift', :git => 'https://github.com/schickling/Device.swift.git', :branch => 'master'

schickling commented 8 years ago

Unfortunately I don't have to time at the moment to actively maintain this repository but I've added you as a collaborator. Please feel free to move forward with this!

RyanRamchandar commented 8 years ago

Great. I'll update this when I get a moment.

RyanRamchandar commented 8 years ago

The podspec is at 0.3.2 already and I added a tag for it also to the latest commit 1eadcde

@schickling if you are the one who initially pushed the pod you will need to do it again unless you add another contributor. https://guides.cocoapods.org/making/getting-setup-with-trunk#adding-other-people-as-contributors

codytwinton commented 8 years ago

+1 on this. The Pod trunk is still version 0.3.1 containing Swift 2.3 code

schickling commented 8 years ago

@RyanRamchandar I think someone else published it via Pods. Back then I've just use carthage.

codytwinton commented 8 years ago

@RyanRamchandar Any update on pod trunk push Device.swift.podspec for the new version?

RyanRamchandar commented 8 years ago

@codytwinton unfortunately I am not a contributor to the pod, and thus can't push it there.

We may need to create a new pod if the current one has become orphaned.

codytwinton commented 8 years ago

@RyanRamchandar Good to know. I'll reach out to @schickling at schickling.j@gmail.com and see what response I can get.

schickling commented 8 years ago

Bad news I guess. Don't really know who efremidzel@hotmail.com is. Maybe you guys should reach out to him.

codytwinton commented 8 years ago

@schickling - Good to know. I posted a contesting of ownership on trunk.cocoapods.org so the pod can go back into your name.

We'll see how that goes…

schickling commented 8 years ago

🎉

codytwinton commented 8 years ago

New Version supporting Swift 3.0 has been pushed.

RyanRamchandar commented 8 years ago

Thanks @codytwinton for taking the initiative on this. Great job!

codytwinton commented 8 years ago

@RyanRamchandar - Absolutely! Also, I created a Pull Request here: #26

Can you take a look and see what you think? Don't want to merge the code without a second pair of eyes to look over the code.