search

schickling / dockerfiles

Collection of lightweight and ready-to-use docker images
https://hub.docker.com/u/schickling/
MIT License
847 stars 366 forks source link

Allow to opt-out of S3 bucket creation in mysql-backup #153

Closed matiasgarciaisaia closed 2 years ago

matiasgarciaisaia commented 2 years ago

This PR allows to revert mysql-backup-to-s3's behaviour to the previous one, in which it didn't check if the S3 bucket existed.

This avoids the need to grant S3 list/read access to the backup user (see #146 for context).

joanfabregat commented 2 years ago

Seems ok to me 👍

iloveitaly commented 2 years ago

Great, thank you! Will push a new docker image as well.