search

schickling / dockerfiles

Collection of lightweight and ready-to-use docker images
https://hub.docker.com/u/schickling/
MIT License
848 stars 367 forks source link

Support extra options in mysql-backup-s3's dump #157

Closed matiasgarciaisaia closed 1 year ago

matiasgarciaisaia commented 1 year ago

MYSQLDUMP_OPTIONS allowed to set the mysqldump command options, but implied setting once again the defaults that the current image already has. The new MYSQLDUMP_EXTRA_OPTIONS gets concatenated to the other variable, allowing the user to add without having to repeat the defaults.

matiasgarciaisaia commented 1 year ago

My use case is to add --no-tablespaces to the mysqldump command (to avoid the need for granting PROCESS privilege to the backup user), without having to repeat the defaults of the image (that I never needed to check, so I assume they are OK as they are).

matiasgarciaisaia commented 1 year ago

I've built this branch into matiasgarciaisaia/mysql-backup-s3:extra-options