Closed atoff closed 1 year ago
@atoff looks great! Could you add a quick note to the readme about this one?
@atoff looks great! Could you add a quick note to the readme about this one?
No worries - I've added a change to apply this to the dump_all option as well 😊
Hey @iloveitaly, any chance of getting this merged? Would love to start using it 😁
@atoff just merged! Thanks for the contribution. I need to update all of the CI stuff to auto-update the Docker hub images, but I don't have the time right now (feel free to sponsor me if you'd like me to dedicate more time to it!).
As part of my use case with backups to S3, I prefer for my backups not to have unique filenames (i.e. timestamps) so that I can use lifecycle rules to appropriately expire non-current versioned items. This feature was previously supported by your
mysql-backup-s3
image, however it doesn't appear to be possible in this image for postgresql.This PR:
postgresql-client
to support PostgreSQL 15S3_FILE_NAME
environment variable which, when supplied, is used as the file name instead of<db>_<timestamp>.sql.gz
S3_BACKUP
env variable initialisation in the Dockerfile as this appears not to be usedPlease let me know if any changes are needed to allow this to be accepted!