schickling / dockerfiles

Collection of lightweight and ready-to-use docker images
https://hub.docker.com/u/schickling/
MIT License
848 stars 367 forks source link

feat(postgres-backup-s3): Support custom backup filename #160

Closed atoff closed 1 year ago

atoff commented 1 year ago

As part of my use case with backups to S3, I prefer for my backups not to have unique filenames (i.e. timestamps) so that I can use lifecycle rules to appropriately expire non-current versioned items. This feature was previously supported by your mysql-backup-s3 image, however it doesn't appear to be possible in this image for postgresql.

This PR:

Please let me know if any changes are needed to allow this to be accepted!

iloveitaly commented 1 year ago

@atoff looks great! Could you add a quick note to the readme about this one?

atoff commented 1 year ago

@atoff looks great! Could you add a quick note to the readme about this one?

No worries - I've added a change to apply this to the dump_all option as well 😊

atoff commented 1 year ago

Hey @iloveitaly, any chance of getting this merged? Would love to start using it 😁

iloveitaly commented 1 year ago

@atoff just merged! Thanks for the contribution. I need to update all of the CI stuff to auto-update the Docker hub images, but I don't have the time right now (feel free to sponsor me if you'd like me to dedicate more time to it!).