schiehll / react-alert

alerts for React
MIT License
608 stars 98 forks source link

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference. #153

Closed anpct closed 4 years ago

anpct commented 4 years ago

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference.

schiehll commented 4 years ago

Yeah, I think we have to update our react-transition-group dependency. I will do that later, or you can submit a PR if you feel like it.

anpct commented 4 years ago

I don't think that's solving the issue.

anpct commented 4 years ago

I think changes need to be done to the code to adapt to the new version of react-transition-group. As stated here: https://github.com/reactjs/react-transition-group/pull/559#issuecomment-557018803

anpct commented 4 years ago

I submitted a PR please check it.

edw19 commented 4 years ago

I have de same error

manishoctal commented 4 years ago

Still the same. Any hack?

schiehll commented 4 years ago

It's just a warning in the dev env because of the react-transition-group. I've just fixed it by updating the dependency.

Try v7.0.2 and see if it's fixed for you. If it's not, I can reopen it.

manishoctal commented 4 years ago

Yes, it is fixed now. Thanks for the quick reply :) Happy coding.

edw19 commented 4 years ago

where I do the changed the version a 7.0.2 ? I reinstall the pakage but not be fix the problem. Can I help me ?

manishoctal commented 4 years ago

@Patricio18 You should check the version in package.json, are you sure about that? Or you can do by uninstall and install again.