search

schiehll / react-alert

alerts for React
MIT License
607 stars 98 forks source link

position top center #29

Closed erebolledo closed 7 years ago

erebolledo commented 7 years ago

Hi guys is there some way for get the position top center? I have been watching the code, but I have couldnt reach. Could you help me? Thanks

jamesguan commented 7 years ago

I agree, this would really be helpful for people who have a very center themed website.

Aj1402 commented 7 years ago

I would like to work on this. It will be possible for a beginner like me!

dennybiasiolli commented 7 years ago

Thanks @Aj1402, if you will submit a PR we will happy to review it!

Aj1402 commented 7 years ago

@dennybiasiolli I am new to reactJS and having trouble with testing the module fom my local directory i have tried using npm link, It shows the following error error

dennybiasiolli commented 7 years ago

@Aj1402 did you already installed npm dependencies with npm install after cloning the repo?

Aj1402 commented 7 years ago

@dennybiasiolli Yes I did

Aj1402 commented 7 years ago

@dennybiasiolli I did the following-> Forked the repo-> Cloned it -> Run npm install -> Made the changes -> Run npm link -> Created a new project -> Wrote some code to run and test alert container -> Run npm link react-alert in new project -> npm start

Aj1402 commented 7 years ago

@dennybiasiolli Alright i resolved the issue did the steps again from start this time it worked!

Sent from my Lenovo A6020a46 using FastHub

schiehll commented 7 years ago

Fixed in #42 by @Aj1402