Added bottom center position

schiehll / react-alert

alerts for React

MIT License

607 stars 98 forks source link

Added bottom center position #40

Closed Aj1402 closed 7 years ago

Aj1402 commented 7 years ago

Added both top center and bottom center positions.

coveralls commented 7 years ago

Coverage decreased (-4.9%) to 95.122% when pulling 769675c7f3e6beec852256bbdf749d6f4a9db5da on Aj1402:newpositions into 9580b8200cfa3c77ef5cb4d5f9625de0fcf859fa on schiehll:master.

Aj1402 commented 7 years ago

Does that mean i need to add some more tests?

coveralls commented 7 years ago

Coverage decreased (-4.9%) to 95.122% when pulling 6355d1ab0cbc6ec2da73a1206f571c271b022116 on Aj1402:newpositions into 9580b8200cfa3c77ef5cb4d5f9625de0fcf859fa on schiehll:master.

coveralls commented 7 years ago

Coverage decreased (-4.9%) to 95.122% when pulling b99c0059ab07c64c6ff858f190c6f6bd37469e13 on Aj1402:newpositions into 9580b8200cfa3c77ef5cb4d5f9625de0fcf859fa on schiehll:master.

Aj1402 commented 7 years ago

@dennybiasiolli Alright changes done, should I create a new PR?

dennybiasiolli commented 7 years ago

Great, thanks! Now you can merge all your commits into a single one:

Added top center and bottom center positioning with code change and tests

Or two commits if you want:

The first with Added top center positioning with code change and tests for that
The second with Added bottom center position with code change and tests for that

Thanks @Aj1402! 😃

dennybiasiolli commented 7 years ago

@Aj1402 no, this PR is ok, but can you please please merge all the commits, adding tests for your edits?

Aj1402 commented 7 years ago

@dennybiasiolli I haven't added tests yet, so ill merge them as soon as I am done with tests

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 35db8ffb0a990be1c83d8dbd9edbb4d3ed1f2000 on Aj1402:newpositions into 9580b8200cfa3c77ef5cb4d5f9625de0fcf859fa on schiehll:master.