Added the possibilty to use a string for offset.

schiehll / react-alert

alerts for React

MIT License

608 stars 98 forks source link

Added the possibilty to use a string for offset. #47

Closed Tseberechts closed 6 years ago

Tseberechts commented 6 years ago

you can now say: offset: '100px 14'. Still not really clean, but I wanted my alerts to come there. it worked, but I got prop-type error.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling 3dee91c37a858a29ebe932c8eb26b880dc81513b on Tseberechts:master into 146a1cfe1c03efe9624c75a471fae27cda95faae on schiehll:master.

schiehll commented 6 years ago

Hey @Tseberechts, thanks for the PR.

v3 supports string now for offset, thank you very much for the idea. v2 will not be maintained anymore, so I'm closing this PR, hope it's ok.