search

schiehll / react-alert

alerts for React
MIT License
607 stars 99 forks source link

withAlert passing other props to the wrapped component #71

Closed felipedeboni closed 6 years ago

felipedeboni commented 6 years ago

Hi,

I ain't sure if it was a design decision, but looks like withAlert doesn't pass to the wrapped component other props besides the alert. This behavior can be checked here.

The following PR "fix" this.

schiehll commented 6 years ago

Oh it's definitely not a design decision. It's a bug introduced in the latest version.

Thank you for the PR, looks awesome, you even added a test for it! Perfect!

I will be releasing a new version with your changes ASAP.