schierlm / BibleMultiConverter

Converter written in Java to convert between different Bible program formats
Other
124 stars 33 forks source link

Improve checking of export arguments to avoid exceptions #35

Closed rkazakov closed 4 years ago

rkazakov commented 4 years ago

Hi @schierlm!

Thanks for fantastic effort in working on this project!

I am trying to import a sample of MyBible module and convert it into Logos.

I run

java -jar BibleMultiConverter-AllInOneEdition.jar MyBibleZone ./AGP.SQLite3 LogosHTML

and get this output:

WARNING: Unclosed <J> tag at:
WARNING: Unclosed <J> tag at:
WARNING: Unclosed <J> tag at:
WARNING: Unclosed <J> tag at:
WARNING: Unclosed <J> tag at:
WARNING: Unclosed <J> tag at:
WARNING: Unclosed <J> tag at:
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1
    at biblemulticonverter.logos.format.LogosHTML.doExport(LogosHTML.java:196)
    at biblemulticonverter.Main.main(Main.java:67)

Import file attached: AGP.zip

Thanks for your help!

Ruslan

rkazakov commented 4 years ago

Sorry, I figured that out! I was missing an export file argument 😀

java -jar BibleMultiConverter-AllInOneEdition.jar MyBibleZone ./AGP.SQLite3 LogosHTML AGP.html

As a suggestion, this could be somehow checked.

Cheers,

Ruslan

schierlm commented 4 years ago

Export argument documentation was improved in #34 already. Better error messages are always possible, but since every format needs a different number of export arguments, it would require changing all the modules and therefore is not a fast&simple fix.

rkazakov commented 4 years ago

Thanks for your reply! All the best with this helpful project!