schikulski / Gromf

WordPress theme based on the Sage(former Roots) starter theme, using Foundation & Gulp.
https://github.com/schikulski/gromf
MIT License
148 stars 18 forks source link

Error with gulp notify #22

Open chriseilander opened 9 years ago

chriseilander commented 9 years ago

Everytime gulp finished doing something it gives the notification of doing so and gives an error directly after it:

gulp-notify: [Error in notifier] Error in plugin 'gulp-notify' notify-send must be installed on the system.

mAAdhaTTah commented 9 years ago

Does it break the gulp watch task or does it just display the error? What OS are you on?

chriseilander commented 9 years ago

No, it just displays the error. I'm on Windows 8.1.

The machine that runs it is actually a server with Linux, I think that matters...

mAAdhaTTah commented 9 years ago

So you're running gulp within the VM using vagrant or something like that? I actually don't think the error matters much; gulp-notify uses notify-send to send the error to Notification Center (in OSX) or your OS's equivalent. I think on Windows it actually pops up a bubble in the lower right.

The problem is because you're running it in the VM and the VM is headless (I presume), there is no notification system for it to send to and it gives you an error. I think there might be a way to pipe it out to your host OS, but it looked complicated even going from Linux -> OSX, so I can't imagine what you'd have to do to -> Win8.1.

All that being said, I think you can just ignore it, if it isn't breaking the watch task. I actually wish we could just suppress the error, because you still get a notification in the terminal (which is how it was previously set up), which still makes it useful, with the additional functionality of it appearing as a visible notification if your system is configured for it.

chriseilander commented 9 years ago

Well at least now I know why it displays that error. An earlier version from here didn't had that (i think) so I was kinda confused when I saw it.

mAAdhaTTah commented 9 years ago

Yeah, I added it in #20. I'll have to look into suppressing the error.