Navitia: queryNearbyLocations requires location.isIdentified()

[grote]

@aelkhour In AbstractNavitiaProvider.java:763 you are using location.isIdentified() instead of location.hasLocation() which breaks querying for locations with LocationType.ANY that only have GPS coordinates.

Other AbstractProviders use location.hasLocation() as well, so I suggest using this here, too. But @schildbach would know that better than me.

[schildbach]

Yes and no. The code after line 763 seems to have both ways to query for nearby stations: 1) by coordinate 2) by stop or poi id of an already identified location

For the first, you should indeed use hasLocation(). For the second, hasId() would be appropriate.

@grote Generally it's a good idea to supply a testcase that shows the error (and has asserts to show how you would expect the API to answer).

[aelkhour]

What is a Location of type LocationType.ANY supposed to represent? I could for instance use the id first then the latlon info if there is no id in order to interpret the location, but what if both members are filled?

[schildbach]

ANY means "we don't know". It's mainly meant for textual user input without the user selecting any type.

It's up to you how you set the priorities. I suggest (in that order)

• ids if type is STATION or POI and an id is present,
• lat/lon if lat/lon is set (type doesn't matter much in this case),
• use name if the API allows (but be prepared for disambiguation).

[grote]

Here's a simple test case:

    @Test
    public void nearbyStationsAny() throws Exception
    {
        final NearbyLocationsResult result = queryNearbyLocations(EnumSet.of(LocationType.STATION), new Location(LocationType.ANY, null, 48877095, 2378431), 700, 10);
        assertEquals(NearbyLocationsResult.Status.OK, result.status);
        print(result);
    }

[grote]

Tested and verified to work. Thanks @aelkhour!