search

schinken / Flash

An Arduino library for smoother, easier access to Flash data.
11 stars 6 forks source link

Pull requests vs. directly commiting #4

Closed schinken closed 8 years ago

schinken commented 8 years ago

@mvhconsult, @nohorbee: What do you think? Directly committing to repository or doing everything with a pull request?

mvhconsult commented 8 years ago

The advantage of pull requests is a good decision tree and checks. But it also means you will be in charge of merging ;). For the moment we can commit directly, but it would be nice to know that we are not doing double work. So I would suggest that you can submit directly if you have been working on a reported issue that was assigned to you. We can always change later if that moves us into troubles.

nohorbee commented 8 years ago

I think that pull requests are fine, as far as the merger is coming from a pool and not a responsibility of a single person. And of course, if I'm doing the pull request, I should not merge ;)

Norberto L. Herz [image: https://www.linkedin.com/pub/norberto-herz/5/887/177] https://www.linkedin.com/pub/norberto-herz/5/887/177 https://twitter.com/nohorbee https://www.facebook.com/nohorbee *"Peace cannot be kept by force. It only can be achieved by understanding"

On Tue, Aug 9, 2016 at 1:06 PM, Michel V. notifications@github.com wrote:

The advantage of pull requests is a good decision tree and checks. But it also means you will be in charge of merging ;). For the moment we can commit directly, but it would be nice to know that we are not doing double work. So I would suggest that you can submit directly if you have been working on a reported issue that was assigned to you. We can always change later if that moves us into troubles.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/schinken/Flash/issues/4#issuecomment-238602500, or mute the thread https://github.com/notifications/unsubscribe-auth/ACKvm1GGnBp3f5FajkSMcXZmcbvw80kaks5qeKV4gaJpZM4JgN_O .

schinken commented 8 years ago

I did some commits directly for moving files etc. But for future changes I want to stay with the pull-request changes. I'm closing this issue, to bring down the counter ;)