DanCardin commented 2 years ago

Docker-py hasn't had a commit in a very long time and appears to be being dropped by docker https://github.com/docker/docker-py/pull/2989.

The relevance to us is that docker-py generates a bunch of internal deprecation warnings that have had PRs available to be merged for a very long time, but haven't been being merged.

https://gabrieldemarmiesse.github.io/python-on-whales/ appears to be an alternative library which avoid reimplementing the docker client functionality, which makes it much simpler, and presumably less likely to cause maintenance issues (such as those warnings).

The risk seems pretty low, given how small a portion of the api surface we use; so it should be trivial to switch back if this becomes a problem, or docker-py gets resumed maintenance and we decide it's better than python-on-whales for any reason

fixes https://github.com/schireson/pytest-mock-resources/issues/156

DanCardin commented 2 years ago

https://github.com/schireson/pytest-mock-resources/issues/156

codecov[bot] commented 2 years ago

Codecov Report

Merging #157 (4420684) into main (dbdca54) will increase coverage by 0.25%. The diff coverage is 54.54%.

:exclamation: Current head 4420684 differs from pull request most recent head 93392d0. Consider uploading reports for the commit 93392d0 to get more accurate results

@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   82.71%   82.96%   +0.25%     
==========================================
  Files          30       30              
  Lines        1313     1303      -10     
  Branches      185      186       +1     
==========================================
- Hits         1086     1081       -5     
+ Misses        187      182       -5     
  Partials       40       40

Impacted Files	Coverage Δ
src/pytest_mock_resources/cli.py	`49.15% <50.00%> (+2.37%)`	:arrow_up:
src/pytest_mock_resources/hooks.py	`71.42% <50.00%> (+1.93%)`	:arrow_up:
src/pytest_mock_resources/container/base.py	`58.13% <60.00%> (-1.87%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 537fc5e...93392d0. Read the comment docs.

schireson / pytest-mock-resources

refactor: Avoid use of dockerpy. #157

Codecov Report