schireson / pytest-mock-resources

Pytest Fixtures that let you actually test against external resource (Postgres, Mongo, Redshift...) dependent code.
https://pytest-mock-resources.readthedocs.io/en/latest/quickstart.html
MIT License
183 stars 19 forks source link

fix: Decide on behavior support for multiple redshift statements. #172

Closed DanCardin closed 2 years ago

DanCardin commented 2 years ago

The multistatement behavior should not be routed through for text objects (and is then i.e. incompatible with 1.4 + warnings or 2.0). the text of text objects can't be reliably pulled out because of params, and it's not clear that pre-rendering it would be without its own quirks, so the prior fix wasn't ideal.

codecov[bot] commented 2 years ago

Codecov Report

Merging #172 (a8e039e) into main (a28c490) will increase coverage by 3.73%. The diff coverage is 97.82%.

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   82.84%   86.58%   +3.73%     
==========================================
  Files          30       31       +1     
  Lines        1306     1394      +88     
  Branches      187      173      -14     
==========================================
+ Hits         1082     1207     +125     
+ Misses        183      150      -33     
+ Partials       41       37       -4     
Impacted Files Coverage Δ
src/pytest_mock_resources/sqlalchemy.py 92.89% <93.75%> (ø)
src/pytest_mock_resources/fixture/moto.py 95.23% <95.23%> (ø)
src/pytest_mock_resources/__init__.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/container/moto.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/credentials.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/__init__.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/base.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/mongo.py 100.00% <100.00%> (ø)
src/pytest_mock_resources/fixture/mysql.py 94.11% <100.00%> (ø)
src/pytest_mock_resources/fixture/postgresql.py 94.66% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.