Dependency on attrs package should be explicit

schireson / pytest-mock-resources

Pytest Fixtures that let you actually test against external resource (Postgres, Mongo, Redshift...) dependent code.

https://pytest-mock-resources.readthedocs.io/en/latest/quickstart.html

MIT License

179 stars 19 forks source link

Dependency on attrs package should be explicit #179

Closed bluetech closed 1 year ago

bluetech commented 1 year ago

Hi, I'm one of the pytest maintainers.

I am working on a PR to pytest that will remove the attrs dependency. This means that plugins that use attrs but do not explicitly require it will break. From a search among pytest plugins, I found that pytest-mock-resources is one such plugin.

attrs is used in this file: https://github.com/schireson/pytest-mock-resources/blob/d522be82cd3a08b886fb504429b315f30d7280eb/src/pytest_mock_resources/patch/redshift/mock_s3_copy.py

bluetech commented 1 year ago

The pytest PR is this: https://github.com/pytest-dev/pytest/pull/10669

DanCardin commented 1 year ago

Thanks for the report! The use of attrs there is really unnecessary anyways

DanCardin commented 1 year ago

v2.6.7 wont have this defect