search

schism-dev / pyschism

Python interface for handling the SCHISM model.
https://schism-dev.github.io/schism/master/getting-started/pre-processing-with-pyschism/overview.html
Apache License 2.0
25 stars 21 forks source link

Bug: Incorrect Setting of Number of Tidal Forcing Constituents in bctides.py #109

Closed yichengt900 closed 1 year ago

yichengt900 commented 1 year ago

The NOS storm surge team, including @SorooshMani-NOAA, @FariborzDaneshvar-NOAA, and myself, is currently setting up a new SCHISM run with nwm source relocation using the most up-to-date pyschism. We have encountered an issue where the nbfr parameter is set incorrectly in the bctides.in file when attempting to use all constituents.

Upon investigation, I have identified a bug in the nbfr function in bctides.py. The correct implementation should be:

return len(self.tides.get_active_forcing_constituents())

Instead of the current implementation:

return len(self.tides.get_active_potential_constituents())

cuill commented 1 year ago

@yichengt900 Thanks for reporting this issue. It has been fixed in the latest release.

cuill commented 1 year ago

Please hold on. It failed when publishing to PyPI.