search

schism-dev / pyschism

Python interface for handling the SCHISM model.
https://schism-dev.github.io/schism/master/getting-started/pre-processing-with-pyschism/overview.html
Apache License 2.0
24 stars 20 forks source link

Understanding new changes in the bctides #111

Closed BahramKhazaei-NOAA closed 10 months ago

BahramKhazaei-NOAA commented 10 months ago

I used to create bctides using the sample code provided here: https://pyschism.readthedocs.io/en/latest/api/boundary.html#tides-type-3

However, in the new version you can't import iettype, ifltype, isatype, itetype anymore: from pyschism.forcing.bctides import Bctides, iettype, ifltype, isatype, itetype

So, basically the error is because the following lines are removed from https://github.com/schism-dev/pyschism/blob/main/pyschism/forcing/bctides/__init__.py:

from pyschism.forcing.bctides.iettype import Iettype
from pyschism.forcing.bctides.ifltype import Ifltype
from pyschism.forcing.bctides.isatype import Isatype
from pyschism.forcing.bctides.itetype import Itetype
from pyschism.forcing.bctides.itrtype import Itrtype

Is this a new approach and how do I change the sample code to define iettype, ifltype, isatype, itetype?

cuill commented 10 months ago

@BahramKhazaei-NOAA The manual for PySCHISM has been incorporated into SCHISM online manual. The one on the readthedocs is no longer updated.

The Bctides API has been changed in the recent release. Arguments iettype, ifltype, isatype, itetype are deprecated. Please check SCHISM online manual for updates: https://schism-dev.github.io/schism/master/getting-started/pre-processing-with-pyschism/bctides.html

BahramKhazaei-NOAA commented 10 months ago

@cuill Thank you very much.