schism-dev / pyschism

Python interface for handling the SCHISM model.
https://schism-dev.github.io/schism/master/getting-started/pre-processing-with-pyschism/overview.html
Apache License 2.0
23 stars 18 forks source link

sources/sinks from NWM: inaccurate intersecting elements #113

Open feiye-vims opened 6 months ago

feiye-vims commented 6 months ago

The boundary elements where sources are injected are found by intersecting the SCHISM land boundary and NWM segments.

Ideally, an intersecting element (i.e., a source element or the parent element of the intersection point) should be identified when the intersection point is found.

However, it seems the source/sink element is found by first finding the intersection point, then searching the nearest element center. This is not equivalent to directly locating the intersecting element and could lead to slight misplacement of sources/sinks.

feiye-vims commented 3 months ago

There is an example script for generating source/sink files inlcuding the json files at: pyschism/examples/NWM/gen_sourcesink.py

Best, Fei

From: lj-cug @.> Sent: Sunday, April 14, 2024 4:46 AM To: schism-dev/pyschism @.> Cc: Fei Ye @.>; Author @.> Subject: Re: [schism-dev/pyschism] sources/sinks from NWM: inaccurate intersecting elements (Issue #113)

[EXTERNAL to VIMS received message]

How can get the files: source.json and sink.json

- Reply to this email directly, view it on GitHubhttps://github.com/schism-dev/pyschism/issues/113#issuecomment-2053969561, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFFRLZ567TJQ4IZAF7EQSJTY5I653AVCNFSM6AAAAABBTPZZNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJTHE3DSNJWGE. You are receiving this because you authored the thread.Message ID: @.**@.>>