`BestTrackForcing` breaks due to update in `StormEvents`

SorooshMani-NOAA commented 1 year ago

BestTrackForcing class inherits VortexTrack. There has been a recent change to the latter (https://github.com/oceanmodeling/StormEvents/pull/74) which breaks the BestTrackForcing class:

  File ".../setup_model.py", line 96, in setup_schism_model
    atmospheric = BestTrackForcing.from_nhc_bdeck(nhc_bdeck=nhc_track_file)
  File ".../pyschism/forcing/nws/best_track.py", line 69, in from_nhc_bdeck
    return cls.from_file(path=nhc_bdeck, start_date=start_date, end_date=end_date)
  File ".../stormevents/nhc/track.py", line 176, in from_file
    return cls(
TypeError: __init__() got an unexpected keyword argument 'file_deck'

cuill commented 1 year ago

@SorooshMani-NOAA Can you take care of this issue? Thanks.

SorooshMani-NOAA commented 1 year ago

Sure, I'll work on this

schism-dev / pyschism

`BestTrackForcing` breaks due to update in `StormEvents` #64