search

schism-dev / schism-esmf

Earth System Modeling Framework cap for SCHISM
5 stars 6 forks source link

mvapich device is not contained in `src/include/Rules.mk` leading to undefined ESMF_FC #13

Closed platipodium closed 2 years ago

platipodium commented 2 years ago

In src/include/Rules.mk we consider openmpi, mpich2, mpich3 and intelmpi devices, but not yet mvapich2. This is available and can be tested on femto.

platipodium commented 2 years ago

There is also a problem in the script with path splitting with -

/sciclone/home20/clemmen/devel/schism/schism-esmf% mpifort -compile_info | cut -d' ' -f1 | cut -d'-' -f1 /usr/local/intel

platipodium commented 2 years ago

Fixed by commit e4a0d9b

josephzhang8 commented 2 years ago

Thx Carsten! I'll need to look at the schism_step(it) carefully after I go back from the conference. It'd not be a problem to make it INT8, which I think is integer(kind=8) in FORT? I'm surprised that this would crash the code..

-Joseph

Joseph Zhang Office: (804) 684 7466 Web: schism.wiki

From: Carsten Lemmen @.> Sent: Sunday, June 5, 2022 4:41 PM To: schism-dev/schism-esmf @.> Cc: Y. Joseph Zhang @.>; Assign @.> Subject: Re: [schism-dev/schism-esmf] mvapich device is not contained in src/include/Rules.mk leading to undefined ESMF_FC (Issue #13)

[EXTERNAL to VIMS received message]

Fixed by commit e4a0d9bhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism-esmf%2Fcommit%2Fe4a0d9b9ad8a69a696e3f6add0f72cb80e29753d&data=05%7C01%7Cyjzhang%40vims.edu%7C5045a8c2b42e46f366a308da4733bd79%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637900584800292503%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=OnAPInB7lWuLMhNasvtcO9P350oFuxzR39LuYOH3tB0%3D&reserved=0

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism-esmf%2Fissues%2F13%23issuecomment-1146880088&data=05%7C01%7Cyjzhang%40vims.edu%7C5045a8c2b42e46f366a308da4733bd79%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637900584800292503%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zjEQMJq0paSYjqSbW9aMFVmhBOHrkTqqtSHjuV1eiaQ%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ6MPQQWBO6AO4XT3HDVNUGGZANCNFSM5X44T2CA&data=05%7C01%7Cyjzhang%40vims.edu%7C5045a8c2b42e46f366a308da4733bd79%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637900584800292503%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eANswbf8%2FvlIFFUgbtYOrLP9TNYcXIWzLS0m6Fx0m5k%3D&reserved=0. You are receiving this because you were assigned.Message ID: @.**@.>>

platipodium commented 2 years ago

Thx Carsten! I'll need to look at the schism_step(it) carefully after I go back from the conference. It'd not be a problem to make it INT8, which I think is integer(kind=8) in FORT? I'm surprised that this would crash the code.. …

Your comment is directed to #15. And there is no crash, as we limit the I8 datatype coming from ESMF to max out (and exit beyond) I4 limit.