search

schism-dev / schism-esmf

Earth System Modeling Framework cap for SCHISM
5 stars 6 forks source link

Change type of it to I8 inside SCHISM #15

Open platipodium opened 2 years ago

platipodium commented 2 years ago

When calling call schism_step(it) we currently need to provide an INT4 as type of it. In ESMF, this is a long int (INT8), and I would recommend also changing to this type for it in SCHISM.

platipodium commented 1 year ago

@josephzhang8 I really believe we should allow more than 32k time steps. At dt=200 s, this would only get us as far as 75 days...(something seems off in my calculation ...)

josephzhang8 commented 1 year ago

FORTRAN int*4 has an upper bound of 2,147,483,648

With dt=100sec, this translates to 2.4 million days.

-Joseph

Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466

From: Carsten Lemmen @.> Sent: Wednesday, August 31, 2022 12:08 PM To: schism-dev/schism-esmf @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [schism-dev/schism-esmf] Change type of it to I8 inside SCHISM (Issue #15)

[EXTERNAL to VIMS received message]

@josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C8372acee37e0426f93ab08da8b6afc38%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637975588882141265%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FLYEL%2FRahgeoQfFEpeu2Lqx1rFa46LG55Xg5oMcrkXA%3D&reserved=0 I really believe we should allow more than 32k time steps. At dt=200 s, this would only get us as far as 75 days...(something seems off in my calculation ...)

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism-esmf%2Fissues%2F15%23issuecomment-1233137699&data=05%7C01%7Cyjzhang%40vims.edu%7C8372acee37e0426f93ab08da8b6afc38%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637975588882141265%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=J%2FothusAOTAkdsEkxaaM%2BEhtyRPVSGdsG%2FuBzeXp%2B%2Fo%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZY6WDVC2HCTNOQTSIDV357OHANCNFSM5X45CJLA&data=05%7C01%7Cyjzhang%40vims.edu%7C8372acee37e0426f93ab08da8b6afc38%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637975588882141265%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IeNrDZAIA%2F8lF7if3ND5EwHVEAp5HlJDu8vKotRNz2E%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

platipodium commented 1 year ago

Thx for correcting me. Would it hurt to use i8 for compatibility with ESMF advancecount?

josephzhang8 commented 1 year ago

Yes in the long term.

-Joseph

Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466

From: Carsten Lemmen @.> Sent: Wednesday, August 31, 2022 3:49 PM To: schism-dev/schism-esmf @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: Re: [schism-dev/schism-esmf] Change type of it to I8 inside SCHISM (Issue #15)

[EXTERNAL to VIMS received message]

Thx for correcting me. Would it hurt to use i8 for compatibility with ESMF advancecount?

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism-esmf%2Fissues%2F15%23issuecomment-1233354119&data=05%7C01%7Cyjzhang%40vims.edu%7C7e5e6632338d4783ef7208da8b89e2f1%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637975721591121034%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HnCWH5pmeFaeiiomkKhIy2AT5SV%2FyRX9ZUmvWVjSjB8%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ25CTMTL7R3WTUT4XDV36ZLXANCNFSM5X45CJLA&data=05%7C01%7Cyjzhang%40vims.edu%7C7e5e6632338d4783ef7208da8b89e2f1%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637975721591121034%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Ln3KUJa1qrHWfFeJxyatjvniaaIqSF678xPpakkSBKI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>