search

schism-dev / schism-esmf

Earth System Modeling Framework cap for SCHISM
5 stars 6 forks source link

Feature/coastal app #24

Closed platipodium closed 1 year ago

platipodium commented 1 year ago

I reviewed your code changes. Thank you! Everything seems straightforward. Thank you, in particular, for keeping to the coding style. I think this is ready to be merged.

josephzhang8 commented 1 year ago

Thx Ufuk, Carsten! @platipodium: please go ahead and merge. Thx.

josephzhang8 commented 1 year ago

@platipodium : I review the new code from Ufuk and it looks fine to me. Plz review and if u r OK, go ahead and approve and merge. Thx.

josephzhang8 commented 1 year ago

@platipodium : I take that back; it seems the PR is in progress and cannot be merged.

platipodium commented 1 year ago

Has been reviews by Joseph and myself and approved.