search

schism-dev / schism-esmf

Earth System Modeling Framework cap for SCHISM
5 stars 6 forks source link

Make ESMF ghost nodes/elemnets optional #26

Open platipodium opened 9 months ago

platipodium commented 9 months ago

It seems we do not need to communicate ghost nodes to ESMF. So next to the current implementations that communicate ghost nodes or ghost nodes alternatively, let's have a clean version that avoids communication of ghost elements entirely.

See downstream issue https://github.com/oceanmodeling/ufs-coastal/issues/2#issuecomment-1699550641

josephzhang8 commented 9 months ago

Thx @platipodium. I think u r the best person to do this overhaul, but I'll review the code.. thx!!!!

uturuncoglu commented 9 months ago

This is now optional in UFS side. We have two routine SCHISM_MeshCreateNode and SCHISM_MeshCreateElement. The second one creates fields on elements without ghost and first one is the original implementation. So, in the calls that fill import and export fields we could also support both.