search

schism-dev / schism-esmf

Earth System Modeling Framework cap for SCHISM
5 stars 6 forks source link

Fix for wave related import fields #31

Closed uturuncoglu closed 2 months ago

uturuncoglu commented 3 months ago

This PR fixes the wave coupling issues that were raised with the debug mode under UFS Coastal and GNU compiler.

The related issue/s: oceanmodeling/schism-esmf#4

uturuncoglu commented 3 months ago

@josephzhang8 I am doing one more test now for GNU and DEBUG. If that also works, I'll change the status of this PR and you could review and merge it.

josephzhang8 commented 3 months ago

@uturuncoglu: so u decided not to move compute*() to util? That's fine with me. @platipodium : can u plz review also. @uturuncoglu asked u a question about the need for NUOPC scripts there, and I'm interested in knowing the answer also, Thx.

uturuncoglu commented 3 months ago

@josephzhang8 I think this is ready for your review. I'll lookout GNU+DEBUG issue later but I don't think it is related with SCHSIM.

josephzhang8 commented 3 months ago

OK thx.

uturuncoglu commented 3 months ago

@josephzhang8 Yes, I did not want to mix things. So, we could look at it later. If you give more information I could help. Which NUOPC scripts?

uturuncoglu commented 3 months ago

@josephzhang8 It would be also better to wait for @pvelissariou1 to make test in his side too before merging this PR. @pvelissariou1 We are waiting for your confirmation.

pvelissariou1 commented 3 months ago

I'll check all SCHISM RTs and report back by Monday.

josephzhang8 commented 3 months ago

@uturuncoglu : at one time u were asking why there are separate caps for ESMF and NUOPC.

platipodium commented 3 months ago

@uturuncoglu : at one time u were asking why there are separate caps for ESMF and NUOPC.

Beyond UFS-Coastal, we use SCHISM also in non-NUOPC coupled ESMF systems, namely MOSSCO. All developments on the NUOPC cap should also carry over into the ESMF cap (or the common esmf_util) if relevant to both coupling constellations.

uturuncoglu commented 3 months ago

@platipodium Thanks for your comments. You could find my answers above. Let me know if you need any further questions.

platipodium commented 3 months ago

@platipodium Thanks for your comments. You could find my answers above. Let me know if you need any further questions.

Not at all, thank you for developing the code further! Shall we wait for @josephzhang8 approval to before merge?

uturuncoglu commented 3 months ago

@platipodium At this point, we are waiting for @pvelissariou1 to do some test in his side.

uturuncoglu commented 2 months ago

@josephzhang8 you could merge this PR since @pvelissariou1 Is able to test the changes and it was all fine in his side.