schism-dev / schism

Semi-implicit Cross-scale Hydroscience Integrated System Model (SCHISM)
http://ccrm.vims.edu/schismweb/
Apache License 2.0
87 stars 86 forks source link

Minor bug in building xmvis6 #146

Open kshedstrom opened 4 days ago

kshedstrom commented 4 days ago

I got this error during the build:

/usr/bin/ld: adc3dwin.o:/home/kate/schism/src/Utility/ACE/xmvis6/adc3dwin.c:820: multiple definition ofcuradc3d'; main.o:/home/kate/schism/src/Utility/ACE/xmvis6/globals.h:161: first defined here`

I commented out line 820 and it compiled. But do you want to be setting that variable to 0 in globals.h?

This was on: Linux skink 6.8.0-45-generic #45-Ubuntu SMP PREEMPT_DYNAMIC Fri Aug 30 12:02:04 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Otherwise an easy build!

josephzhang8 commented 3 days ago

Hi Kate:

Unless you want to visualize particle tracking results, you do not need xmvis6 (which was written to visualize the binary format outputs from older versions). The error is due to upgrade in C compilers - the code is dated.

-Joseph

Joseph Zhang

Office: (804) 684 7466

Web: schism.wiki


From: Kate Hedstrom @.> Sent: Thursday, September 26, 2024 4:36 PM To: schism-dev/schism @.> Cc: Subscribed @.***> Subject: [schism-dev/schism] Minor bug in building xmvis6 (Issue #146)

[EXTERNAL to VIMS received message]

I got this error during the build:

/usr/bin/ld: adc3dwin.o:/home/kate/schism/src/Utility/ACE/xmvis6/adc3dwin.c:820: multiple definition of curadc3d'; main.o:/home/kate/schism/src/Utility/ACE/xmvis6/globals.h:161: first defined here`

I commented out line 820 and it compiled. But do you want to be setting that variable to 0 in globals.h?

This was on: Linux skink 6.8.0-45-generic #45https://github.com/schism-dev/schism/pull/45-Ubuntu SMP PREEMPT_DYNAMIC Fri Aug 30 12:02:04 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Otherwise an easy build!

— Reply to this email directly, view it on GitHubhttps://github.com/schism-dev/schism/issues/146, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFBKNZ7Y4VTOC5NLC4Z3AY3ZYRV6XAVCNFSM6AAAAABO5ZVGMWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2TCNBYHE2TQMY. You are receiving this because you are subscribed to this thread.Message ID: @.***>