Conditionally (on nws/ihconsv setting) provided atmsopheric vars thro…

schism-dev / schism

Semi-implicit Cross-scale Hydroscience Integrated System Model (SCHISM)

http://ccrm.vims.edu/schismweb/

Apache License 2.0

93 stars 88 forks source link

Conditionally (on nws/ihconsv setting) provided atmsopheric vars thro… #43

Closed platipodium closed 3 years ago

platipodium commented 3 years ago

Please @wzhengui check that this works for you and merge after testing.

wzhengui commented 3 years ago

Hi Carsten:

I reviewed the code and tested it with my FABM_COSINE_SFBay case. Generally, it is good.

1). There is one minor issue. on line 730, if (nws == 2 and ihconsv == 1) then

2). self%par is not computed for _FABM_APIVERSION > 1. This may cause light issue as you mentioned if you call par in your model. In my COSINE model, I used par0 instead of par.

I will approve the PR, and fix the 1st minor issue. I will leave the 2nd issue to you to fix it.

Best, Zhengui