search

schism-dev / schism

Semi-implicit Cross-scale Hydroscience Integrated System Model (SCHISM)
http://ccrm.vims.edu/schismweb/
Apache License 2.0
78 stars 84 forks source link

Refactor the light calculation for FABM0 #44

Closed platipodium closed 2 years ago

platipodium commented 2 years ago

Please check that this branch runs with your cosine test case, then merge

wzhengui commented 2 years ago

Okay, I will test it, and merge later. Zhengui

On Saturday, September 11, 2021, Carsten Lemmen @.***> wrote:

Please check that this branch runs with your cosine test case, then merge

You can view, comment on, or merge this pull request online at:

https://github.com/schism-dev/schism/pull/44 Commit Summary

  • Added condidional memory allocation for many environmental variables (only if requested by model)
  • Reintroduced bottom_stress, need USE_SED for epsf calculation
  • Merge branch 'master' into fabm
  • Merge branch 'master' into fabm
  • Replace epsf with q2 for calculation of bottom TKE
  • Fixed missing type for bottm_standard_variable in FABM1
  • Updated node interpolation of bottom tke
  • Add correct udunits time string for FABM output
  • Revised par calculation for FABM0
  • Ignore DS_Store and _version from git
  • Make missing_value consistent with FABM -2E20 value

File Changes

Patch Links:

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/schism-dev/schism/pull/44, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFFROBMMDSNQMMA6DMWS2G3UBM6TZANCNFSM5D24F2BA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- null