schism-dev / schism

Semi-implicit Cross-scale Hydroscience Integrated System Model (SCHISM)
http://ccrm.vims.edu/schismweb/
Apache License 2.0
78 stars 84 forks source link

Updating ST6 Physics in WWM #72

Open huyquangtranaus opened 2 years ago

huyquangtranaus commented 2 years ago

Hi Joseph @josephzhang8 @aronroland I like to put ST6 physics in WWM module within SCHISM source code. Indeed, I did it more than 2 years ago in SCHISM 5.6 during my PhD, but there have been a lot of changes in SCHISM source code until now. Therefore, I need some extra work.

I am thinking of forking SCHISM git repo so that I can work on it from my github projects, but I am not sure if that is a best way. Do you have any suggestion?

Thank you

josephzhang8 commented 2 years ago

Hi Huy:

Thx for the heads-up. I suggest you coordinate with Xavier's team and Aron on this first to make sure they have not already done this. It's usually easier to fork off and then issue a PR later, but make sure you fork off from the latest master. Thx.

-Joseph

Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466

From: Huy Quang Tran @.> Sent: Tuesday, June 14, 2022 7:40 AM To: schism-dev/schism @.> Cc: Y. Joseph Zhang @.>; Mention @.> Subject: [schism-dev/schism] Updating ST6 Physics in WWM (Issue #72)

[EXTERNAL to VIMS received message]

Hi Joseph @josephzhang8https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjosephzhang8&data=05%7C01%7Cyjzhang%40vims.edu%7C6dedb6dc6a074acbcae008da4dfaa240%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637908036108817298%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZmImewntPZdtHw4KtNOoFvGaz%2F66Xlrsif7NKp4k%2FhE%3D&reserved=0 @aronrolandhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faronroland&data=05%7C01%7Cyjzhang%40vims.edu%7C6dedb6dc6a074acbcae008da4dfaa240%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637908036108817298%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zH79OULWxXqdWCVpxu1atSh7UGq3EJzNoyrVp%2Fb9nFM%3D&reserved=0 I like to put ST6 physics in WWM module within SCHISM source code. Indeed, I did it more than 2 years ago in SCHISM 5.6 during my PhD, but there have been a lot of changes in SCHISM source code until now. Therefore, I need some extra work.

I am thinking of forking SCHISM git repo so that I can work on it from my github projects, but I am not sure if that is a best way. Do you have any suggestion?

Thank you

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fissues%2F72&data=05%7C01%7Cyjzhang%40vims.edu%7C6dedb6dc6a074acbcae008da4dfaa240%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637908036108817298%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IW1VDpVUOjlOsPXPQcW%2FY%2BmelF9lv2f5l1htKAXn4Uo%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ4PHSQTQN5OHTA25WTVPBVRRANCNFSM5YXMLWDQ&data=05%7C01%7Cyjzhang%40vims.edu%7C6dedb6dc6a074acbcae008da4dfaa240%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637908036108817298%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NHTMhHQLPxotGhI1zQVWagAUxREADV1hPN4RCEZg2UA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.**@.>>

josephzhang8 commented 2 years ago

Dear all,

no, we did not work on ST6 source terms in la Rochelle. With WWIII, we usually get our best results with ST4 source terms with the lattest parameterizations of Fabrice Ardhuin (test 473 or 475) and would would like to update these in WWM in the coming months.

Cheers,

Xavier

Le 14/06/2022 à 13:46, Y. Joseph Zhang a écrit :

to put ST6 physics in WWM module within SCHISM source code. Indeed, I did it more than 2 years ago in SCHISM 5.6 during my PhD, but there have been a lot of changes in SCHISM source code until now. Therefore, I need some extra work.

-- Xavier Bertin, Directeur de recherches au CNRS Coordinateur scientifique du SNO DYNALIT: http://www.dynalit.fr UMR 7266 LIENSs CNRS/La Rochelle Université 2 rue Olympe de Gouges 17000 La Rochelle tel: 05 46 50 76 36 page web: https://lienss.univ-larochelle.fr/Bertin-Xavier-DR

josephzhang8 commented 2 years ago

Thx, Xavier. So Huy: please work on your fork and then we merge with PR later. Thx.

-Joseph

Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466

-----Original Message----- From: Xavier Bertin @.> Sent: Tuesday, June 14, 2022 8:44 AM To: Y. Joseph Zhang @.>; schism-dev/schism @.>; schism-dev/schism @.> Cc: Mention @.***> Subject: Re: [schism-dev/schism] Updating ST6 Physics in WWM (Issue #72)

[EXTERNAL to VIMS received message]

Dear all,

no, we did not work on ST6 source terms in la Rochelle. With WWIII, we usually get our best results with ST4 source terms with the lattest parameterizations of Fabrice Ardhuin (test 473 or 475) and would would like to update these in WWM in the coming months.

Cheers,

Xavier

Le 14/06/2022 à 13:46, Y. Joseph Zhang a écrit :

to put ST6 physics in WWM module within SCHISM source code. Indeed, I did it more than 2 years ago in SCHISM 5.6 during my PhD, but there have been a lot of changes in SCHISM source code until now. Therefore, I need some extra work.

-- Xavier Bertin, Directeur de recherches au CNRS Coordinateur scientifique du SNO DYNALIT: https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.dynalit.fr%2F&data=05%7C01%7Cyjzhang%40vims.edu%7Cfea5621472e2400efc3408da4e037d94%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637908074169332813%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Q9zclvWuFlX2MCQUhZ%2FHF8mXeQN8jeDS%2BopfZowQBpQ%3D&reserved=0 UMR 7266 LIENSs CNRS/La Rochelle Université 2 rue Olympe de Gouges 17000 La Rochelle tel: 05 46 50 76 36 page web: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flienss.univ-larochelle.fr%2FBertin-Xavier-DR&data=05%7C01%7Cyjzhang%40vims.edu%7Cfea5621472e2400efc3408da4e037d94%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637908074169332813%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=0UaRtcIL7JBBLyy3U0tgloLa1kChSxcUUJCev24dqJQ%3D&reserved=0

aronroland commented 2 years ago

Dear Huy, we have a implementation in WWM-V of ST6. However, Sashas group was very active on this work in WW3. The best way to proceed would be to use the WW3 code of ST6, however, I am not sure about the licensing issues. U may also want to consider that very soon SCHISM will be hard coupled to to WW3, which would make your work obsolete. I will also suspend WWM-III support after reaching this goal. Cheers Aron