search

schism-dev / schism

Semi-implicit Cross-scale Hydroscience Integrated System Model (SCHISM)
http://ccrm.vims.edu/schismweb/
Apache License 2.0
87 stars 86 forks source link

updated the PaHM sources to their latest version as of 07/19/2022 #75

Closed pvelissariou1 closed 2 years ago

pvelissariou1 commented 2 years ago

This brings the PaHM sources in SCHISM to their latest version. It also fixes the compilation of SCHISM using the GFortran and OpenMPI combination.

josephzhang8 commented 2 years ago

Thx Takis for working on this. I'll review as soon as I'm done with some urgent tasks.

-Joseph

Joseph Zhang Office: (804) 684 7466 Web: schism.wiki

From: Panagiotis Velissariou @.> Sent: Tuesday, July 19, 2022 5:29 PM To: schism-dev/schism @.> Cc: Y. Joseph Zhang @.>; Review requested @.> Subject: [schism-dev/schism] updated the PaHM sources to their latest version as of 07/19/2022 (PR #75)

[EXTERNAL to VIMS received message]

This brings the PaHM sources in SCHISM to their latest version. It also fixes the compilation of SCHISM using the GFortran and OpenMPI combination.

You can view, comment on, or merge this pull request online at:

https://github.com/schism-dev/schism/pull/75https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fpull%2F75&data=05%7C01%7Cyjzhang%40vims.edu%7C737b4e52eb3242cd438008da69cdb5d9%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637938629505176802%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9uZ73hM6GnDXV7G%2F9eG%2Fo8cIYswXwgaPukItRq9NwDg%3D&reserved=0

Commit Summary

File Changes

(11 fileshttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fpull%2F75%2Ffiles&data=05%7C01%7Cyjzhang%40vims.edu%7C737b4e52eb3242cd438008da69cdb5d9%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637938629505176802%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=lb11HsZh1OKMQl32O4eKartvOrDRzv9GutfdN0yK4fQ%3D&reserved=0)

Patch Links:

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fpull%2F75&data=05%7C01%7Cyjzhang%40vims.edu%7C737b4e52eb3242cd438008da69cdb5d9%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637938629505333937%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4Y6Ak6xbZOQVbG7XYSOUgULMBekjNmkWV2ZiGk2S%2FLQ%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ75YHAAVJVF2XSQN3DVU4M2FANCNFSM54BMODKA&data=05%7C01%7Cyjzhang%40vims.edu%7C737b4e52eb3242cd438008da69cdb5d9%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637938629505333937%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=SPNcr3FepXZZuzQcAxz7fQb9bvvCJ%2BPKMbzwvzSeh%2Fg%3D&reserved=0. You are receiving this because your review was requested.Message ID: @.**@.>>

josephzhang8 commented 2 years ago

Soroosh confirmed that the new code did not crash on gcc. Need more tests but merge to master now.

josephzhang8 commented 2 years ago

Hi Takis:

You might want to close cmmb branch for now. In the future if you work on PaHM only and your changes do not interfere with other modules, feel free to directly push into master. Thank you!

-Joseph

Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466

From: Joseph Zhang @.> Sent: Thursday, July 21, 2022 10:22 AM To: schism-dev/schism @.> Cc: Y. Joseph Zhang @.>; Your activity @.> Subject: Re: [schism-dev/schism] updated the PaHM sources to their latest version as of 07/19/2022 (PR #75)

[EXTERNAL to VIMS received message]

Merged #75https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fpull%2F75&data=05%7C01%7Cyjzhang%40vims.edu%7C0b1ace6b558643dd7ff408da6b2464d2%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637940101313806147%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xuQz%2FRigUiovH3M19uyofAGFmkBBa8kI6Re2e%2FoIlJs%3D&reserved=0 into master.

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fpull%2F75%23event-7038803288&data=05%7C01%7Cyjzhang%40vims.edu%7C0b1ace6b558643dd7ff408da6b2464d2%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637940101313806147%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RP3RUa8Ys%2BkiEhiHyYazB8TtQ1FJFYV95nEcU2%2BQCnY%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ227YWDLSTOGXX3LOLVVFMI7ANCNFSM54BMODKA&data=05%7C01%7Cyjzhang%40vims.edu%7C0b1ace6b558643dd7ff408da6b2464d2%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637940101313806147%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JVamQ59Fh0MnY3ZBp%2F4LW%2FTgVETJk%2FX3Fvp%2FyLkdCEg%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

josephzhang8 commented 2 years ago

Ok, will do.

Takis

Panagiotis Velissariou, Ph.D., P.E. UCAR Scientist National Ocean and Atmospheric Administration National Ocean Service Office of Coast Survey CSDL/CMMB Project Lead - Coastal Coupling cell: (205) 227-9141 email: @.***

On Thu, Jul 21, 2022 at 9:24 AM Y. Joseph Zhang @.***> wrote:

Hi Takis:

You might want to close cmmb branch for now. In the future if you work on PaHM only and your changes do not interfere with other modules, feel free to directly push into master. Thank you!

-Joseph

Y. Joseph Zhang

Web: schism.wiki

Office: 804 684 7466

From: Joseph Zhang @.> Sent: Thursday, July 21, 2022 10:22 AM To: schism-dev/schism @.> Cc: Y. Joseph Zhang @.>; Your activity < @.> Subject: Re: [schism-dev/schism] updated the PaHM sources to their latest version as of 07/19/2022 (PR #75)

[EXTERNAL to VIMS received message]

Merged #75 https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fpull%2F75&data=05%7C01%7Cyjzhang%40vims.edu%7C0b1ace6b558643dd7ff408da6b2464d2%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637940101313806147%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xuQz%2FRigUiovH3M19uyofAGFmkBBa8kI6Re2e%2FoIlJs%3D&reserved=0 into master.

— Reply to this email directly, view it on GitHub https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fpull%2F75%23event-7038803288&data=05%7C01%7Cyjzhang%40vims.edu%7C0b1ace6b558643dd7ff408da6b2464d2%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637940101313806147%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RP3RUa8Ys%2BkiEhiHyYazB8TtQ1FJFYV95nEcU2%2BQCnY%3D&reserved=0, or unsubscribe https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ227YWDLSTOGXX3LOLVVFMI7ANCNFSM54BMODKA&data=05%7C01%7Cyjzhang%40vims.edu%7C0b1ace6b558643dd7ff408da6b2464d2%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637940101313806147%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JVamQ59Fh0MnY3ZBp%2F4LW%2FTgVETJk%2FX3Fvp%2FyLkdCEg%3D&reserved=0 . You are receiving this because you are subscribed to this thread.Message ID: @.***>