:coffin: dead/deprecated/backup codes in the main branch

jamal919 commented 2 years ago

Following up on issue #58, it seems to me that src/WWMIII.Sept2020 has reached its time for deprecation (2-years). Two tag release has been created since the creation of this backup, and the current WWMIII also received some bug fixes and new features e.g., https://github.com/schism-dev/schism/commit/40baa99e2299c440381045d3692784a0e8cdaaf3, https://github.com/schism-dev/schism/commit/6524e19c5d5edca7d5c60eb4234c7d44bfdbe015, https://github.com/schism-dev/schism/commit/3906b0cec4859b51910add7f1a39a21df7dc160e, https://github.com/schism-dev/schism/commit/567b61235fa9a815ac7b4fa19984fca42fa9f381, https://github.com/schism-dev/schism/commit/73f7e1b36f16987fab0373baac012074db41f25c, https://github.com/schism-dev/schism/commit/ff5ad7546c5cec721e83f4ec55484d43e5a160bb, https://github.com/schism-dev/schism/commit/9b711aff8ee2c382e24e175a3b5b2e9a0b4761b5.

IMO, as everything is already tracked by git, we would be able to checkout to this exact version in the foreseeable future with git checkout <sha> command after removal. As such, backup folders of codes seems to be only contributing to make the folder structure unnecessarily convoluted.

Thanks.

josephzhang8 commented 2 years ago

Removed.

josephzhang8 commented 1 year ago

I agree. I'll remove that dir if Aron and Xavier are good with that. Thx Jamal for the reminder.

-Joseph

Joseph Zhang Office: (804) 684 7466 Web: schism.wiki

From: Jamal Uddin Khan @.> Sent: Saturday, September 10, 2022 7:17 AM To: schism-dev/schism @.> Cc: Subscribed @.***> Subject: [schism-dev/schism] :coffin: dead/deprecated/backup codes in the main branch (Issue #83)

[EXTERNAL to VIMS received message]

IMO, as everything is already tracked by git, we would be able to checkout to this exact version in the foreseeable future with git checkout command after removal. As such, backup folders of codes seems to be only contributing to make the folder structure unnecessarily convoluted.

Thanks.

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fissues%2F83&data=05%7C01%7Cyjzhang%40vims.edu%7Cad82d520f4644aa264be08da931ded02%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637984054006883727%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Osc2yFiyLYjtaQnWvp7kE1fQdPyUb4%2FVmSk1a12kg68%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ6G23OKJXMND4ASHTDV5RUZHANCNFSM6AAAAAAQJJLREE&data=05%7C01%7Cyjzhang%40vims.edu%7Cad82d520f4644aa264be08da931ded02%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C637984054006883727%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=cxOYgXDAoOKHhW%2FijFk45S6eSXbuAmfpinK9gT9ayhc%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

jamal919 commented 1 year ago

Hello Joseph,

I am guessing the the messages are coming (or being delivered) later. You actually took care of the folder about 1 month ago.

Thanks.

josephzhang8 commented 1 year ago

Yeah I received a lot of old messages from github this morning.

-Joseph

Y. Joseph Zhang Web: schism.wiki Office: 804 684 7466

From: Jamal Uddin Khan @.> Sent: Tuesday, October 11, 2022 9:07 AM To: schism-dev/schism @.> Cc: Y. Joseph Zhang @.>; State change @.> Subject: Re: [schism-dev/schism] :coffin: dead/deprecated/backup codes in the main branch (Issue #83)

[EXTERNAL to VIMS received message]

Hello Joseph,

I am guessing the the messages are coming (or being delivered) later. You actually took care of the folder about 1 month ago.

Thanks.

- Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fschism-dev%2Fschism%2Fissues%2F83%23issuecomment-1274659417&data=05%7C01%7Cyjzhang%40vims.edu%7Cb6a2ac1f7b5341667b4d08daab896a09%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638010903922736307%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xBfH7XXzYvXqeUOqY5ncV8Lb1uBnvvjcvODzkiBVjKU%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFBKNZ4RI7IETSZLLJGPL4TWCVQ5NANCNFSM6AAAAAAQJJLREE&data=05%7C01%7Cyjzhang%40vims.edu%7Cb6a2ac1f7b5341667b4d08daab896a09%7C8cbcddd9588d4e3b9c1e2367dbdf1740%7C0%7C0%7C638010903922736307%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NSfcKo2e2baC7pxcHr4sAvhclTlbJUE0pljFbUvlHYI%3D&reserved=0. You are receiving this because you modified the open/close state.Message ID: @.**@.>>

jamal919 commented 1 year ago

I see! I suspected so. FYI, I also have schism-dev/schism followed, but did not receive the messages. It seems it is isolated to you perhaps.

With best of luck.

schism-dev / schism

:coffin: dead/deprecated/backup codes in the main branch #83