Closed schlagmichdoch closed 9 months ago
hi @schlagmichdoch! i loaded this branch but it doesn't seem to work. i did the following:
chmod +x pairdrop-cli/pairdrop
pairdrop-cli/pairdrop 1.txt 2.txt
pairdrop-cli/pairdrop *.txt
Expected result: it opened my browser to share both files Actual result: i got the CLI help:
if that's not the expected process, please lmk the testing instructions?
hey @schlagmichdoch, good catch! i removed the one from PATH
and tried it directly again:
@ChaosExAnima Great that’s resolved!
Apparently, negative numbers in substring extractions are not supported in older bash versions. I’ll fix this.
The is only needed on Windows Powershell though. Could you comment out line 167 (by adding a #) and try it again?
okay, that works! just for the record, this is my bash version:
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin23) Copyright (C) 2007 Free Software Foundation, Inc.
okay, that works! just for the record, this is my bash version:
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin23) Copyright (C) 2007 Free Software Foundation, Inc.
Awesome thanks! That confirms what I thought.
I have just force-pushed the changes that should resolve this. Would you try again one last time? :)
works great!
The following comments were deleted by GitHub (via hubot) as part of mistakenly marking this account as spam on 17th February 2024. The correct thread order and the creation date is unclear. I decided to manually restore them anyway in order to complete the information this issue holds even though the restored information might be outdated:
Hey @ChaosExAnima,
I have reworked pairdrop-cli
on this branch to be able to handle multiple files and directories simultaneously. I'd appreciate it, if you would quickly test this on MacOS before I add this with the new release.
Would you happen to be free?
Thanks for your help @ChaosExAnima!
Your instructions would be correct, but if I understand your screenshot correctly, you don’t use the local ./pairdrop
but the global pairdrop
cmd you have in PATH. This is probably the old version which checks for the number of arguments and shows the help if there are too many.
Have you tried using ./pairdrop
?
This removes the File Handling API as it is overwriting default file registrations (#17, #116, #190)
To replace the possibility to send files via context menu this PR extends the pairdrop-cli to handle multiple files.
Also, this introduces files and documentation (todo) how to set this up on different platforms to send files via the context menu
Todo
pathsPS=${pathsPS%??}