search

schlagmichdoch / PairDrop

PairDrop: Local file sharing in your browser. Inspired by Apple's AirDrop. Fork of Snapdrop.
https://pairdrop.net
GNU General Public License v3.0
3.66k stars 193 forks source link

[Enhancement] Bring back the water ripples background animation #285

Open loveu5522 opened 3 months ago

loveu5522 commented 3 months ago

snapdrop of Water ripples are moveable

schlagmichdoch commented 1 month ago

I have responded to this question before:

The background animation is abolished purposely. Firstly, the behavior is inconsistent as implemented into Snapdrop, as it does not start again when all peers have left. This was fixed in the beginning of PairDrop. But secondly, this animation (and all versions with a smarter logic I tried) are a heavy strain on CPU and/or GPU. See https://github.com/schlagmichdoch/PairDrop/issues/75 and https://github.com/schlagmichdoch/PairDrop/commit/b42c8a0b1a1e0522af2b21a7d980183627735cd3 In the end I decided to remove the background animation in favor of speed and efficiency. I also prefer the calmness of the GUI when the PWA is running all the time.

If you really miss this, please create a new separate issue for it. If enough users really do like the animation I will try to come up with a way without it straining the CPU/GPU (probably removing transparency changes would help).

Originally posted by @schlagmichdoch in https://github.com/schlagmichdoch/PairDrop/issues/210#issuecomment-2086011791

Although this is more or less a duplicate I'll leave this to be decided. If enough people prefer some background animation I'll maybe try to come up with a way.