schlangster / skyui

SkyUI interface mod for Skyrim.
271 stars 170 forks source link

1.6.1130 added a new option, breaking the gameplay options menu #97

Open ianpatt opened 11 months ago

ianpatt commented 11 months ago

The options list in onSettingsCategoryFrame in 1.6.1130 is now:

{text:"$Invert Y",movieType:2},
{text:"$Look Sensitivity",movieType:0},
{text:"$Vibration",movieType:2},
{text:"$360 Controller",movieType:2},
{text:"$SaveGameMissingCreationsCheck",movieType:2},
{text:"$Survival Mode",movieType:2},
{text:"$Difficulty",movieType:1,options:["$Very Easy","$Easy","$Normal","$Hard","$Very Hard","$Legendary"]},
{text:"$Show Floating Markers",movieType:2},
{text:"$Save on Rest",movieType:2},
{text:"$Save on Wait",movieType:2},
{text:"$Save on Travel",movieType:2},
{text:"$Save on Pause",movieType:1,options:["$5 Mins","$10 Mins","$15 Mins","$30 Mins","$45 Mins","$60 Mins","$Disabled"]},
{text:"$Use Kinect Commands",movieType:2}];

The new $SaveGameMissingCreationsCheck option causes the rest of the options to be off by one.

Mardoxx commented 11 months ago

Thanks, been a long time!

I shall dust off my old gear and try and get this sorted.

On Thu, 7 Dec 2023 at 04:51, Ian Patterson @.***> wrote:

The options list in onSettingsCategoryFrame in 1.6.1130 is now:

{text:"$Invert Y",movieType:2}, {text:"$Look Sensitivity",movieType:0}, {text:"$Vibration",movieType:2}, {text:"$360 Controller",movieType:2}, {text:"$SaveGameMissingCreationsCheck",movieType:2}, {text:"$Survival Mode",movieType:2}, {text:"$Difficulty",movieType:1,options:["$Very Easy","$Easy","$Normal","$Hard","$Very Hard","$Legendary"]}, {text:"$Show Floating Markers",movieType:2}, {text:"$Save on Rest",movieType:2}, {text:"$Save on Wait",movieType:2}, {text:"$Save on Travel",movieType:2}, {text:"$Save on Pause",movieType:1,options:["$5 Mins","$10 Mins","$15 Mins","$30 Mins","$45 Mins","$60 Mins","$Disabled"]}, {text:"$Use Kinect Commands",movieType:2}];

The new $SaveGameMissingCreationsCheck option causes the rest of the options to be off by one.

— Reply to this email directly, view it on GitHub https://github.com/schlangster/skyui/issues/97, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2QMILCUCX2KJ7DI2R3ETYIFDNDAVCNFSM6AAAAABAKOHWHCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDSOBZGU2TMMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Exit-9B commented 11 months ago

On a similar note, there was a change to the Journal System Tab in patch 1.6.629 that added a "Creations" item. SkyUI doesn't break anything else by not including it, but it would be nice to fix.

Mardoxx commented 11 months ago

Going to be more difficult than I thought it would be

Also would have to get schlangster to upload to steam store.

Someone could create a “fix” which included the required changes to the pause menu and load order would have to be such a way that it takes preference.

On Thu, 7 Dec 2023 at 15:24, Parapets @.***> wrote:

On a similar note, there was a change to the Journal System Tab in patch 1.6.629 that added a "Creations" item. SkyUI doesn't break anything else by not including it, but it would be nice to fix.

— Reply to this email directly, view it on GitHub https://github.com/schlangster/skyui/issues/97#issuecomment-1845546175, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB2QMLCN76KRFNXFOLILPTYIHNTBAVCNFSM6AAAAABAKOHWHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGU2DMMJXGU . You are receiving this because you commented.Message ID: @.***>

ianpatt commented 11 months ago

Only the classic 32-bit version of Skyrim has integration with the Steam workshop, so it'd probably just need to go up on Nexus.

I locally patched quest_journal.swf to verify the fix, but that was a huge kludge. For cross-version compatibility, it should also only add the "missing creations check" option when the version is 1.6.1130 or newer, which I didn't do either.

nerwus3456 commented 11 months ago

So that's why Dear Diary Dark Mode didn't have the "Creations" option. TIL