Improve Async Operations

schlatt-co / stonks

Jschlatt sub server company management plugin

Apache License 2.0

3 stars 1 forks source link

Closed Tsarcasm closed 4 years ago

Tsarcasm commented 4 years ago

This branch improves the overall maintainability and readability of the codebase.

Removed lots of unnecessary asynchronous code (mainly using taskchains)
All GUIs inherit from InventoryGui, providing consistent instantiation and a show(player) method for each gui
Removed some unnecessarily verbose builder classes
ConfirmationGUI has a better builder, separating lambdas for "Yes" and "No" selections
General UI tweaks and improvements

Tsarcasm commented 4 years ago

Looks good, however, please remove the chain as a dependency in gradle

We do still depend on that for a couple cases