Closed thomasmerz closed 4 months ago
😃
Thanks a lot for not giving up on teaching me better Bash, I'll take a look at this. I also appreciate your pushing rear
to become better.
TBH, I've had already some cases where I really struggled to make shellcheck
happy with the way how I like to use Bash. So I remain curious to see how this goes.
It's hard to get used the shellcheck
style… Or even the shfmt
style (next level!)… But… when you got used to it, you will love it ❤️
If you want I can try a PR for fixing + a fancy GitHub Action for you repo. But I'm not sure if you want "my" solution or the one from the rear repo/PR? 🤷🏼♂️
@schlomo , do you have an opinion about this issue? PR or not?
Shellcheck is haunting me... RBME is very much in a "just works" stage of its life. I'd be happy to accept PRs that improve stuff, especially introducing things that play well with ReaR but I won't find the time to work on this myself now. If I have time then I'd rather spend it on https://chromein.de/ FYI (although RBME might still have more users).
Let's see what happens, worst case I'll adopt https://github.com/rear/rear/blob/master/.github/workflows/differential-shellcheck.yml instead :-)
This Red Hat Plumber/Dev is doing also a great job 👍🏼 But it is also a little bit oversized for your little small project (but suits perfect for rear
- and I'm out of support for this 😃).
Hi @schlomo , you really should use some kind of
shellcheck
for yourrbme
Shell Script: