search

schlosser / eventum

An event-driven CMS that syncs with Google Apps
21 stars 15 forks source link

Strip HTML from text #125

Closed bluemelodia closed 9 years ago

bluemelodia commented 9 years ago

I have left the print statements and main in for now, in case you would like to test further. The test case attached contains an image that should be removed entirely, and two HTML links. screen shot 2014-11-22 at 3 19 12 pm

natebrennand commented 9 years ago

There's a lot of commented out code in this pull request that needs to be cleaned up

schlosser commented 9 years ago

Hey @bluemelodia make sure that your pull request only includes files that are related driectly to the issue you're resolving. In this case, it should only be text.py. If you're not sure how to fix that, we can go over it next Friday.

bluemelodia commented 9 years ago

Hi @danrschlosser I kept the print and main statements in case you wanted to test with different statements; but if not I can take them out

schlosser commented 9 years ago

Those are okay for now, but either way all of the unittest stuff should be removed.

bluemelodia commented 9 years ago

Removed init.py and test_events.py from the commit; also removed the comments specifying what the function should do - I left in the main method and test case in for now

schlosser commented 9 years ago

This PR is on :yellow_heart: (hold), pending adding tests.

schlosser commented 9 years ago

I think this should be done with regexes, not text.index().