Closed DerGoogler closed 1 month ago
I really appreciate the effort, however, could you provide a real-life use case for this? I feel like it's just overcomplicating something that can be done by opening the releases page and searching for the desired version (should always have the latest one anyway).
@schmaldeo thanks. It downloads the selected releases into C:\Program Files\DS4Windows without having to open chrome, unpack etc
I'd say if you add an option to choose between hand-picked version and latest (with an emphasis on latest too) I can merge.
I have updated the script:
C:\Users\<USER>\AppData\Local\DS4Windows
@schmaldeo
Thank you for the contribution :)
@schmaldeo I'm think I'm gonna fork the DS4Updater instead. I've seem that you also update the newest.txt
file and I wanna try something new ;)
It's a legacy option now, due to https://github.com/schmaldeo/DS4Windows/pull/16/commits/4c7e439aa2a34efdb889acca3d0ed4ca361d22f0.
newest.txt update for v3.7.3 was the last one required, as from now on the latest version number is not checked against that file, but rather against GitHub API.
The updater could maybe do with a bit of a refresh (the only work I've done on it was change the links to point to my repos rather than Ryochan's), but I've seen that @major-sanyi also forked it.
I've already done a bit
GitHub API may be a lot of requests and ending in a rate limit
@schmaldeo I'm using https://raw.githubusercontent.com/schmaldeo/DS4Windows/refs/heads/master/DS4Windows/DS4WinWPF.csproj
to greo the latest release from <Version>
, so newest.txt
it not really a need
I've already done a bit
GitHub API may be a lot of requests and ending in a rate limit
The rate limit for unathenticated requests are 60 per hour per IP. Unless someone spams the check update, I don't think the rate limit is reached realistically. And it's possible to get all of the releases in 1 go if you want to experiment with Different versions.
Also added install instructions to the readme file