schmaldeo / DS4Windows

DS4Windows but maintained
GNU General Public License v3.0
113 stars 8 forks source link

Add updater script (for users) #19

Closed DerGoogler closed 1 month ago

DerGoogler commented 1 month ago

Also added install instructions to the readme file

schmaldeo commented 1 month ago

I really appreciate the effort, however, could you provide a real-life use case for this? I feel like it's just overcomplicating something that can be done by opening the releases page and searching for the desired version (should always have the latest one anyway).

DerGoogler commented 1 month ago

@schmaldeo thanks. It downloads the selected releases into C:\Program Files\DS4Windows without having to open chrome, unpack etc

schmaldeo commented 1 month ago

I'd say if you add an option to choose between hand-picked version and latest (with an emphasis on latest too) I can merge.

DerGoogler commented 1 month ago

I have updated the script:

@schmaldeo

schmaldeo commented 1 month ago

Thank you for the contribution :)

DerGoogler commented 1 month ago

@schmaldeo I'm think I'm gonna fork the DS4Updater instead. I've seem that you also update the newest.txt file and I wanna try something new ;)

schmaldeo commented 1 month ago

It's a legacy option now, due to https://github.com/schmaldeo/DS4Windows/pull/16/commits/4c7e439aa2a34efdb889acca3d0ed4ca361d22f0.

newest.txt update for v3.7.3 was the last one required, as from now on the latest version number is not checked against that file, but rather against GitHub API.

The updater could maybe do with a bit of a refresh (the only work I've done on it was change the links to point to my repos rather than Ryochan's), but I've seen that @major-sanyi also forked it.

DerGoogler commented 1 month ago

I've already done a bit

image

GitHub API may be a lot of requests and ending in a rate limit

DerGoogler commented 1 month ago

@schmaldeo I'm using https://raw.githubusercontent.com/schmaldeo/DS4Windows/refs/heads/master/DS4Windows/DS4WinWPF.csproj to greo the latest release from <Version>, so newest.txt it not really a need

major-sanyi commented 1 month ago

I've already done a bit

image

GitHub API may be a lot of requests and ending in a rate limit

The rate limit for unathenticated requests are 60 per hour per IP. Unless someone spams the check update, I don't think the rate limit is reached realistically. And it's possible to get all of the releases in 1 go if you want to experiment with Different versions.

https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28

https://api.github.com/repos/schmaldeo/DS4Windows/releases