schmaldeo / DS4Windows

DS4Windows but maintained
GNU General Public License v3.0
49 stars 2 forks source link

[Feature Request] On "Special Actions" > "Press/Toggle key" add option to select controller buttons #21

Open Caio99BR opened 3 days ago

Caio99BR commented 3 days ago

Describe the feature request On Press/Toggle key add option to select the buttons of the controller and not just the keyboard

To Reproduce Steps to reproduce the behavior:

  1. Go to "Profiles" > "Edit" > "Special Actions" > "New Action" > "Press/Toggle key"
  2. It shows only keyboard and mouse

Expected behavior: Show this screen image

Current behavior image

Desktop:

Additional context I want to simulate touchpad actions on a PS3 controller using "Select" + "Another key" and I don't see another way to do it

schmaldeo commented 2 days ago

Could you not achieve it by recording a macro?

In this window click on Record, press the desired buttons on the controller, then click on Stop and Save

Back is DS3 Select, DS4 Share, but it doesn't matter as what matters is what you're physically pressing on the controller, it's just that the button names are mapped to X360's controller's ones.

Caio99BR commented 2 days ago

No, because I want to simulate the "Touchpad press" from PS4 controller (And well I don't own a PS4 controller)

schmaldeo commented 2 days ago

OK, I'll work on it. As a temporary workaround if you want to have it now, create a macro that you want, use some different button instead of touchpad, go to your config directory (by default %appdata%/DS4Windows/Profiles/name.json), scroll down to <Macro> section and replace that button's ID with 286 (e.g. if you want to map Select to simple touchpad press, it should be:

<Macro>
   <Share>286/286</Share>
</Macro>

).

I reckon I'll work on it later this week, after I'm done with https://github.com/schmaldeo/DS4Windows/issues/20.

Caio99BR commented 7 hours ago

Ah I see, I din't understand at first how Macro works but I did it. Also it's located in a different place (%appdata%/DS4Windows/Actions.xml)

-> Another thing, if I try to do it on type key (<Details>286</Details>), the program will load it as None -> If use <Details>286/286</Details> on type key the program crash when trying to load the profile (well, not a problem since we shouldnt edit this file anyway)

image

Caio99BR commented 7 hours ago

I thing Record a macro should be something else like Insert a macro (but just an opinion, it's up to the user check the behavior of this option)

schmaldeo commented 5 hours ago

If I'm honest I haven't initlally thoroughly read through your feature request and automatically replied to it. I've made my first steps to add what you have requested and I reckon it will be available next week at latest.