schmaldeo / DS4Windows

DS4Windows but maintained
GNU General Public License v3.0
76 stars 6 forks source link

DualSense connection error in Version 3.9.2-beta.2 #32

Open redomCL opened 1 week ago

redomCL commented 1 week ago

DualSense connection error in Version 3.9.2. Version 3.9.1 no error. log: QQ截图20241009211441

schmaldeo commented 1 week ago

As a temporary fix, please revert back to 3.9.1.

@nefarius any ideas for why it would do this? No issue on DS4, also it's in the write method, just forgot to change the exception's message. Haven't got a DualSense to debug it myself, is there a chance the buffer is initialised with a wrong size? Doesn't make much sense considering it worked with streams + I haven't changed anything in how the buffer is set up.

nefarius commented 1 week ago

Can take a look when fit again, currently knocked out with the 'Rona.

schmaldeo commented 1 week ago

Alright take your time and hope you feel better soon 🙂

nefarius commented 1 day ago

@schmaldeo just tried it with a DS, can't reproduce it. @redomCL what exactly did you do to provoke this problem?

redomCL commented 1 day ago

@schmaldeo 只是用 DS 试过了,无法重现。 @redomCL 您究竟做了什么来引发这个问题?

I just install this QQ截图20241016085856 my windows version: 2 bluetooth: intel ac9260 with bluetooth,driver version: 3

Driver store explorer list: 4

My DS has been updated to the latest firmware via PlayStation Accessories: 5

redomCL commented 1 day ago

@schmaldeo just tried it with a DS, can't reproduce it. @redomCL what exactly did you do to provoke this problem?

By the way,I had installed dshidmini driver for use ds3 图片

schmaldeo commented 1 day ago

To me the thing that would seem most likely to cause it is the controller's software update, would be easiest to check if that's it if you had another pc/laptop. On another hand, the output buffer is initialised to a size that's fetched from the HID collection using HidP_GetCaps(), wouldn't really make sense for it to return wrong values?

Anyway - really hard for me to say anything without having physical access to that hardware, if you've got another computer available, please check if the problem persists, maybe @nefarius could have some more ideas.

redomCL commented 23 hours ago

I'm sorry, I didn't test the latest v3.9.3-beta.1 before. now I just tested this version and the problem has disappeared. This problem for me only exists in this version: https://github.com/schmaldeo/DS4Windows/releases/tag/v3.9.2-beta.2

schmaldeo commented 22 hours ago

That's because these are 2 separate versions from separate branches - 3.9.3-beta.1 still uses the old FileStream-based I/O. In stable 3.9.3 the P/Invoke I/O (so the one from 3.9.2-beta.2) will become the only available option, so it's important to make sure it works well on all devices.

nefarius commented 22 hours ago

So..... Not an issue or...? I tested from master branch directly.

schmaldeo commented 22 hours ago

3.9.3 beta is from lightbar-macro, 3.9.2 beta features are in master branch, so we're interested either in this release or alternatively in a self-compiled master. I've commited these changes since that release but I'm certain these don't have any affect on this issue.

@redomCL as i said, checking if the issue persists on another machine with the same controller and this version would be a very important step towards fixing it for you.

Side note on why the versioning is so chaotic in this example - I first merged the P/Invoke changes to master and released that as latest, but after this issue popped up i changed it to a pre-release. Lightbar macro is still its own branch so it gets a separate patch number.

redomCL commented 21 hours ago

The same issues occurs on my other laptop 7300HQ intel ac 3160 with bluetooth,v3.9.2-beta.2 QQ截图20241016232945