Allow pluggable QR code analyzers

schmich / instascan

HTML5 QR code scanner using your webcam

https://schmich.github.io/instascan/

MIT License

2.95k stars 866 forks source link

Allow pluggable QR code analyzers #34

Open schmich opened 7 years ago

schmich commented 7 years ago

https://github.com/LazarSoft/jsqrcode
https://github.com/zz85/quirc.js
https://github.com/ghybs/zxingjs2
WebAssembly build of Java ZXing
Create multiple builds, one per library?
Create an uber build that uses all simultaneously?

pocesar commented 7 years ago

ZXing is abandoned (js version), maybe use https://github.com/edi9999/jsqrcode or https://github.com/cozmo/jsQR?

schmich commented 7 years ago

@pocesar Are you seeing any perf/recognition issues with the current setup?

I don't wan't to stick with an abandoned library, but the plan right now is:

Short-term: stick with the current setup (emscripten'd build of the C++ port of ZXing) unless there are serious issues
Medium-term: Add adapters for pluggable QR code libraries if there is demand for it
Long-term: As WebAssembly gets implemented in the various major browsers, investigate integration with the original Java ZXing implementation via wasm

pocesar commented 7 years ago

@schmich actually, I'm not having any issues, the only problem I see in the proposal for plugins, is maintainability. each library have a different API, so you'd need to create a plugin interface between them and release / maintain them. and also, we don't know issues that may arise, since ZXing ported version has been abandoned (at least by taking a look at their repo)

styfle commented 6 years ago

Long-term: As WebAssembly gets implemented in the various major browsers, investigate integration with the original Java ZXing implementation via wasm

Yes! This would be excellent! I see that today, WASM is available in about 65% of browsers in the wild. If you take into account only the latest version of each browser, then WASM is 100% supported 💯