search

schmidtfa / pyrasa

a package for spectral parametrization in python based on the IRASA algorithm
https://schmidtfa.github.io/pyrasa/
BSD 2-Clause "Simplified" License
7 stars 1 forks source link

Irasa sprint improvements #52

Closed schmidtfa closed 2 months ago

schmidtfa commented 2 months ago

This pr tackles some core issues with pyrasa_sprint. There was sth wrong with the previous implementation that resulted in some weird artifacts from time to time. This is fixed now alongside #22 , #30 and #31. However, in order to do so I had to go back to use scipy.signal.stft which was recently marked a legacy function from scipy. @thht there are ways to tweak the newer scipy.signal.ShortTimeFFT towards producing an output like scipy.signal.stft (see Comparison with Legacy Implementation in https://docs.scipy.org/doc/scipy/tutorial/signal.html#tutorial-stft), but I didnt manage to do so yet..

schmidtfa commented 2 months ago

Issues resolved, example added and testing intensified :) merging