search

schmittjoh / JMSDiExtraBundle

Provides Advanced Dependency Injection Features for Symfony2
http://jmsyst.com/bundles/JMSDiExtraBundle
330 stars 129 forks source link

Symfony autowiring broken by JMSDiExtraBundle #282

Open Aerendir opened 7 years ago

Aerendir commented 7 years ago

It seems that the bunde breaks the autowiring functionalities of Symfony, making it impossible to use them.

All the etails in the ticket opened in the Symfony's issue tracker: https://github.com/symfony/symfony/issues/23200#issuecomment-309171399

Kadbury1989 commented 6 years ago

Its really a pain that this issue still exists. Is there any active development going on to fix this?

ostrolucky commented 6 years ago

also see https://github.com/symfony/symfony/issues/27053

schmittjoh commented 6 years ago

I'm not sure we still need this bundle given the addition of autowiring and recent improvements to it.

Could you tell us a bit more what features you still use of this bundle that are not supported by the Symfony dependency injection container itself?

ostrolucky commented 6 years ago

Personally I use no features of this bundle, it's just required by jmsjobqueuebundle

schmittjoh commented 6 years ago

If you use the symfony4 branch, this requirement should not be there anymore.

ostrolucky commented 6 years ago

That's nice, but I'm hesitant to use dev branches in production. There should be a push for merging the branch and release it.

Aerendir commented 6 years ago

I was using it only because required by JMSTranslationBundle. No other feature used.

Unfortunately I was forced to remove both to make Symfony autowiring work...

rvanlaak commented 6 years ago

Same here, would be great if JMSJobQueueBundle would not have a hard dependency on jms/di-extra-bundle in the case that symfony/symfony: ^3.4|^4.0 is used.

What would it take to let the symfony4 branch support symfony ^3.4|^4.0 instead of only ^4?