search

schmittjoh / JMSI18nRoutingBundle

Allows you to internationalize your routing
http://jmsyst.com/bundles/JMSI18nRoutingBundle
358 stars 159 forks source link

Translation logging fix #144

Closed cmfcmf closed 9 years ago

cmfcmf commented 9 years ago

Only look at the second commit to see the actual changes.

This resolves #141. It does an extra check for the LoggingTranslator, because it didn't implement the TranslatorBagInterface until Symfony version 2.6.5 (see https://github.com/symfony/symfony/issues/13632).

craigh commented 9 years ago

ping @schmittjoh

ecentinela commented 9 years ago

ping @schmittjoh

schmittjoh commented 9 years ago

Before merging, could you have a look at the line endings, it seems like something went wrong there?

cmfcmf commented 9 years ago

They were wrong in the original file, which I fixed in https://github.com/cmfcmf/JMSI18nRoutingBundle/commit/ba8be27e582236835df03cce7052a140bf5922a8.

craigh commented 9 years ago

@schmittjoh is there still a concern?

stof commented 9 years ago

@cmfcmf can you submit the line-ending change separately, so that it can be merged first (meaning that after rebasing, this PR will have a meaningful diff which can be revewed)

schmittjoh commented 9 years ago

@stof, btw, you can add ?w=1 to get rid of the whitespace changes.

craigh commented 9 years ago

thank you for merging. do you intent another tagged release anytime soon?