search

schmittjoh / JMSI18nRoutingBundle

Allows you to internationalize your routing
http://jmsyst.com/bundles/JMSI18nRoutingBundle
358 stars 159 forks source link

Compatibility for symfony3 #162

Closed sansonthomas closed 9 years ago

sansonthomas commented 9 years ago

Hy, I replace the method getPattern() and setPattern() by getPath() and setPath().

I've done tests in symfony 2.7 so I'm not sure if there is a BC for older versions.

Thx

stof commented 9 years ago

getPath is supported as of Symfony 2.2. and Symfony 2.1 is long dead. So it is fine IMO.

However, it looks like you messed a rebasing. when rebasing a feature branch, you need to force the push to github (as you rewrote the history). If you merge the (non-rebased) remote branch with the rebased local branch to be able to perform a fast-forward push, you are duplicating the history in the remote branch (see the list of commits)